-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add globalSlugs option #543
Conversation
Changes: Adds globalSlugs parameter to the extension paramters. When set to false, the extension behaves as it historically has. If set to true, the slugger and headers list are not reset on each parse. When set to true, the slugger and headers[] persist until the new `resetheadings` function is called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests and docs to the README for this method
Correct function inline documentation.
`globalSlugs usage - Pre-Clearing.` Does not clear the headers before the test run, combining it with the results of the previous test. Runs two passes through marked. `globalSlugs usage - Pre-Clearing.` Clears before running the test, only outputting parsing results from this test. Runs two passes through marked. `globalSlugs usage - Pre and middle clearing.` Clears before and after the first pass. Runs two passes through marked.
Let me know if these updates are adequate. |
Co-authored-by: Tony Brix <[email protected]>
Co-authored-by: Tony Brix <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking with this! 💯
# [3.2.0](v3.1.3...v3.2.0) (2024-06-10) ### Features * add globalSlugs option ([#543](#543)) ([41da687](41da687))
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes:
Adds globalSlugs parameter to the extension paramters. When set to false, the extension behaves as it historically has. If set to true, the slugger and headers list are not reset on each parse.
When set to true, the slugger and headers[] persist until the new
resetheadings
function is called.