Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Refactor styling #134

Open
Rumperuu opened this issue Apr 22, 2021 · 1 comment
Open

Refactor styling #134

Rumperuu opened this issue Apr 22, 2021 · 1 comment
Assignees
Labels
invalid This doesn't seem right workflow Workflow improvements wpcs-compliance WordPress Coding Standards conformance
Milestone

Comments

@Rumperuu
Copy link
Collaborator

Rumperuu commented Apr 22, 2021

Currently, we have 8 CSS stylesheets in the css/ dir (ignoring the minified ones that are still tracked in version control for reasons:tm:). When building the Plugin for release, these are concatenated in various combinations into a bunch of footnotes-<code>.css files, which are then minified and linked conditionally based on user-defined settings (which are used to build the <code>).

There are a number of issues with this:

As part of #87, I will also look into how we can reorganise this. For example, starting to refactor the stylesheets into SCSS to make namespacing more reliable, splitting components into individual files, etc. Once we have a proper CSS build pipeline in place, this should have the knock-on effect of removing the need for the build_stylesheets.sh command, as we'll be able to define much more fine-grained stylesheets to be conditionally imported (and, of course, we can roll in #88 as well).

@Rumperuu Rumperuu added invalid This doesn't seem right wpcs-compliance WordPress Coding Standards conformance workflow Workflow improvements labels Apr 22, 2021
@Rumperuu Rumperuu added this to the 2.8.0 milestone Apr 22, 2021
@Rumperuu Rumperuu self-assigned this Apr 22, 2021
@markcheret
Copy link
Owner

please, yes. SCSS sounds like a step in the right direction. Generally, any widely used and available templating, build and rollout friendly system... So yeah, I'm all for it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right workflow Workflow improvements wpcs-compliance WordPress Coding Standards conformance
Projects
None yet
Development

No branches or pull requests

2 participants