Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The agent source code does not coverage #250

Open
jasonLaster opened this issue Mar 4, 2015 · 1 comment
Open

The agent source code does not coverage #250

jasonLaster opened this issue Mar 4, 2015 · 1 comment

Comments

@jasonLaster
Copy link
Member

Previously we were not able to run in node because of globals

We could run in the browser and then post back coverage

@paulfalgout
Copy link
Member

Some notes here.

For the life of me I could not successfully get lcov files from any form of html spec runner. Maybe its possible on this project, but I don't think it is as straight-forward as grunt config.. I expect it will take some extra rearranging, but it could also be related to my inexperience with generating lcov info from anything other than a node environment. @samccone ?

We probably could get the agent to run in node, except we have some pretty specific requirements based on some modified unwrapped library files, and some of the library files in use are not commonjs ready.

I'd ideally like to see agent nearly if not entirely extracted into it's own module loading.. perhaps babel? over the grunt preprocess/IIFE solution we have now.. but it will take some finagling to get the libraries loading the way they're needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants