-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Benchmark.js to measure performance #3182
Comments
Very nice idea! 👍 |
Totally agree, I think it'll be a great addition 👍 |
https://github.com/rafde/backbone.marionette/tree/benchmark-runner
Other than that, I notice some strangeness
Where "Current" is from the lib folder and "Latest" is from src I cherry picked my branch into another branch off master and the result is what you see above. The results on who is slower varies a bit where sometime latest is fastest The difference being that one uses ES2015 (src) and one is transpiled (lib) Now I have to figure out if
Looking at 1 would have me transpile src in temp for benchmarking and make sure the result is close to 1. 2 seems likely (since I know me is usually 80% right all the time). |
I recall seeing some articles from the Chrome team saying they'd not optimised many ES2015 features yet (including |
So I tested it using transpiled latest vs current and it still doesn't look right. The best perf flips between each and the slowness varies. My next step is to see if I can use V8 console profiling to determine if its more consistent in giving performance analysis compared to Benchmark.js |
This is kind of a dup of #2267 but with a proposal to use Benchmark.js
It could/should be included in the PR checks. Although it might display false reports in performance due to thread hiccup.
With all the performance work and claims I've been doing, it'd be nice to have a way to show that I am actually making a difference with the work.
Environment
The text was updated successfully, but these errors were encountered: