Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"closest" -> "destroyst" #25

Open
alxndr opened this issue Aug 6, 2014 · 3 comments
Open

"closest" -> "destroyst" #25

alxndr opened this issue Aug 6, 2014 · 3 comments

Comments

@alxndr
Copy link

alxndr commented Aug 6, 2014

upgrade.py wants to replace a call to jQuery's $.fn.closest with destroyst. It appears to be finding the "close" substring and trying to replace with "destroy".

      isInteractive: ($target) ->
-       $target.closest('.actions').length or $target.is('.close')
+       $target.destroyst('.actions').length or $target.is('.close')

      showThumbnail: ->

Potentially related: #21

@samccone
Copy link
Member

samccone commented Aug 6, 2014

but man destroyst would be awesome

@alxndr
Copy link
Author

alxndr commented Aug 6, 2014

For the record it then asks to change .is('.close') to .is('.destroy') as well. Not sure if that's really intended.

@alxndr
Copy link
Author

alxndr commented Aug 6, 2014

...also this means that the check for itemView » childView happened to find and replace all my itemViewOptions with childViewOptions before the actual itemViewOptions » childViewOptions check happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants