Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

negative cost with negative weights #404

Open
tomsbergmanis opened this issue Feb 24, 2023 · 0 comments
Open

negative cost with negative weights #404

tomsbergmanis opened this issue Feb 24, 2023 · 0 comments
Labels

Comments

@tomsbergmanis
Copy link

tomsbergmanis commented Feb 24, 2023

The documentation says that word weights can be real-valued. Real numbers can be negative. This is convenient because outputs of models one could use for scoring often output log-likelihoods, which are negative numbers.
image
However, using negative weights results in a negative cost value, which, if minimized, maximizes the error:
image

  • If this is a mistake in the documentation, could we update the documentation to say "non-negative numbers"?
  • If not, could we update the documentation with the steps to be taken to avoid divergence with negative weights?

Cheers,
Toms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant