Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor from GetterDaily to new GetterMonthly class #7

Open
maread99 opened this issue May 19, 2022 · 0 comments
Open

Refactor from GetterDaily to new GetterMonthly class #7

maread99 opened this issue May 19, 2022 · 0 comments
Labels
code improvement Efficiency improvement, efficacy unchanged (refactoring, speed improvements etc) TODO What it says on the tin

Comments

@maread99
Copy link
Owner

daterange.GetterDaily accommodates getting dateranges for both daily and monthly prices, although the former is assessed against an xcals.ExchangeCalendar and the latter against the gregorian calendar.

Review whether would be cleaner to define a dedicated GetterMonthly class, perhaps with GetterDaily and GetterMonthly having a common subclass.
@maread99 maread99 added TODO What it says on the tin code improvement Efficiency improvement, efficacy unchanged (refactoring, speed improvements etc) labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code improvement Efficiency improvement, efficacy unchanged (refactoring, speed improvements etc) TODO What it says on the tin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maread99