Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Las Vegas track image missing #312

Closed
fl380 opened this issue Nov 7, 2023 · 7 comments · Fixed by #316
Closed

Las Vegas track image missing #312

fl380 opened this issue Nov 7, 2023 · 7 comments · Fixed by #316
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@fl380
Copy link

fl380 commented Nov 7, 2023

Describe the bug
A placeholder is visible where the track image should be displayed

Expected behavior
Track image has been visible for all previous races including Brazil on Sunday

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: chrome and firefox
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: iPhone 12/Android Tablet
  • OS: iOS17.1/unknown
  • Browser HA App
  • Version [e.g. 22]
@fl380 fl380 added the bug Something isn't working label Nov 7, 2023
@marcokreeft87 marcokreeft87 added enhancement New feature or request dependencies Pull requests that update a dependency file and removed bug Something isn't working labels Nov 7, 2023
@marcokreeft87
Copy link
Owner

Yes I was waiting for this issue, unfortunately I'm not going to be able to find a solution for this before the race is over. The fact is, the source of the images doesnt have the image for this because its from 2018.

Combine this with the fact that the API is deprecated I will find a solution for this when I have a replacement for the API.
For now you could hide the tracklayout to hide the "image not found" image

@fl380 fl380 closed this as completed Nov 7, 2023
@JAudi23
Copy link

JAudi23 commented Nov 12, 2023

I'm not a coder, but the image is available, is there no way to pull it into the integration?
https://www.formula1.com/en/racing/2023/Las_Vegas/Circuit.html

image

@bkbartk
Copy link

bkbartk commented Nov 15, 2023

You could just hardcode it,
I did,
I was to lazy to write a proper escape
but that also overwrites the layout of the last GP, or any GP for that matter.
image
so for now I will just hide the track of previous races

@mrdroopy
Copy link

@marcokreeft87 the image is there in that same source: https://www.formula1.com/content/dam/fom-website/2018-redesign-assets/Circuit%20maps%2016x9/Las_Vegas_Circuit.png.transform/7col/image.png so you should be able to pull it using the Las_Vegas_Circuit name.

@marcokreeft87
Copy link
Owner

Thnx for the research. Now I have to find some time to implement it

@marcokreeft87 marcokreeft87 linked a pull request Nov 16, 2023 that will close this issue
@marcokreeft87
Copy link
Owner

marcokreeft87 commented Nov 16, 2023

v1..8.9 fixed it. Thnx @mrdroopy !

You need to empty cache!

@mrdroopy
Copy link

Graag gedaan and thanks to you for the quick fix @marcokreeft87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants