Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer update when releasing a new version #13

Closed
shaffe-fr opened this issue May 11, 2021 · 4 comments
Closed

Composer update when releasing a new version #13

shaffe-fr opened this issue May 11, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@shaffe-fr
Copy link
Contributor

Hi @marcocesarato,
Since commit ea8fb7e, composer update is run automatically when releasing a new version.
Updating the dependecies is not always trivial, it can lead to unexpected bugs and I think that its outside this package boundaries.
May I ask you why you decided to run composer update when creating releases?

Thanks

@marcocesarato
Copy link
Owner

marcocesarato commented May 11, 2021

Hi, it's related the this implementation #11 so to update the version key on composer.lock
I'll add soon an option on config to avoid to update the project dependencies.

@shaffe-fr
Copy link
Contributor Author

Hi, I can't find my project version number in my composer.lock. In what node should it be stored?

@marcocesarato
Copy link
Owner

I've not found it some of my project but the guy who proposed the features said

Also, add the version key to composer.lock

And to be sure of that I inserted a composer update but in fact I don't find it.
Probably is better remove it

@marcocesarato marcocesarato added the bug Something isn't working label May 11, 2021
@shaffe-fr
Copy link
Contributor Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants