From 16b23850d37e95deb709f26e4e2e6d17a475deef Mon Sep 17 00:00:00 2001 From: Marco Castelluccio Date: Thu, 3 Oct 2019 09:06:26 +0000 Subject: [PATCH] Bug 1479539 [wpt PR 12237] - Fix RTCPeerConnection-transceivers.https.html bug., a=testonly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Automatic update from web-platform-testsFix RTCPeerConnection-transceivers.https.html bug. This PR accidentally made the "addTrack(0 streams)" test call addTrack() with a stream, which broke the tests: https://github.com/web-platform-tests/wpt/pull/12141 Test restored and all "addTrack/addTransceiver(X streams)" are made to consistently use "new MediaStream()" the same way. Bug: 869036 Change-Id: Ieaf0c73a1996aeb2e87e18f2f9065fa1e6fee1e7 Reviewed-on: https://chromium-review.googlesource.com/1155125 Reviewed-by: Harald Alvestrand Commit-Queue: Henrik Boström Cr-Commit-Position: refs/heads/master{#579341} -- wpt-commits: 6468c69f9f9e5925f6af370ad127a72c3adc14ed wpt-pr: 12237 UltraBlame original commit: e5221e193074c83a7ee7028a0ca894d8268490f2 --- testing/web-platform/meta/MANIFEST.json | 2 +- .../RTCPeerConnection-transceivers.https.html | 23 +++++++++++++------ 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/testing/web-platform/meta/MANIFEST.json b/testing/web-platform/meta/MANIFEST.json index 946d5937a5c0e..8c6e78ea62fba 100644 --- a/testing/web-platform/meta/MANIFEST.json +++ b/testing/web-platform/meta/MANIFEST.json @@ -4307009,7 +4307009,7 @@ html : [ " -49f683911e61bf7e0c0466e6d6a91f2f70ab30e6 +c89737c99fcebe76b1156499cb7269e7b0a67af1 " " testharness diff --git a/testing/web-platform/tests/webrtc/RTCPeerConnection-transceivers.https.html b/testing/web-platform/tests/webrtc/RTCPeerConnection-transceivers.https.html index 384ea62092e67..6bb825972d0dc 100644 --- a/testing/web-platform/tests/webrtc/RTCPeerConnection-transceivers.https.html +++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-transceivers.https.html @@ -2929,7 +2929,6 @@ const [ track -stream ] = await @@ -3024,7 +3023,6 @@ const [ track -stream ] = await @@ -3033,6 +3031,14 @@ t ) ; +const +stream += +new +MediaStream +( +) +; pc1 . addTransceiver @@ -3150,7 +3156,6 @@ const [ track -stream ] = await @@ -3324,7 +3329,6 @@ const [ track -stream ] = await @@ -3338,7 +3342,6 @@ addTrack ( track -stream ) ; const @@ -3414,7 +3417,6 @@ const [ track -stream ] = await @@ -3423,6 +3425,14 @@ t ) ; +const +stream += +new +MediaStream +( +) +; pc1 . addTrack @@ -3534,7 +3544,6 @@ const [ track -stream ] = await