Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaCO3 burial improvement needs to be added to CISO #82

Closed
mnlevy1981 opened this issue Jun 30, 2016 · 2 comments
Closed

CaCO3 burial improvement needs to be added to CISO #82

mnlevy1981 opened this issue Jun 30, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@mnlevy1981
Copy link
Collaborator

Keith added some new features that made it to the POP trunk (pre-MARBL) in November of 2015: part of the cesm_pop_2_1_20151117 trunk tag. This incudes

introduce caco3_bury_thres_opt, default=omega_calc

Part of this commit is a block of code that is now in marbl_mod

          if (zw(k) < caco3_bury_thres_depth) then
             P_CaCO3%sed_loss(k) = P_CaCO3%sflux_out(k) + P_CaCO3%hflux_out(k)
          endif

But the similar block of code in marbl_ciso_mod is

       if (column_zw < 3300.0e2_r8) then
          flux = P_CaCO3_ciso%sflux_out(k) + P_CaCO3_ciso%hflux_out(k)
          P_CaCO3_ciso%sed_loss(k) = flux
       endif

(There are probably other blocks of code that also need to be updated, this was the easiest to find to provide an example). Note that this is tied to #24 because we may end up removing zw from MARBL (so these threshold depths would be compared to zt)

@mnlevy1981 mnlevy1981 added this to the Finalize MARBL API milestone Jun 30, 2016
@mnlevy1981 mnlevy1981 self-assigned this Dec 6, 2017
@klindsay28
Copy link
Collaborator

The ciso version of CaCO3 burial does not depend on caco3_bury_thres_iopt, like the base ecosys version does. I think this qualifies as a bug.

I think this discrepancy would be caught if we implemented #204.

@mnlevy1981
Copy link
Collaborator Author

Fixed in marbl0.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants