Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several PFT types have confusing names and dimensions #317

Closed
mnlevy1981 opened this issue Sep 7, 2018 · 2 comments
Closed

Several PFT types have confusing names and dimensions #317

mnlevy1981 opened this issue Sep 7, 2018 · 2 comments
Assignees
Milestone

Comments

@mnlevy1981
Copy link
Collaborator

  1. Rename the following:

    • autotroph_secondary_species_type -> autotroph_derived_terms_type
    • zooplankton_secondary_species_type -> zooplankton_derived_terms_type
    • autotroph_type -> autotroph_settings_type
    • zooplankton_type -> zooplankton_settings_type
  2. Move (autotroph_cnt, km) dimensions into autotroph_local_type and autotroph_derived_terms_type [same for (zooplankton_cnt, km) and the zooplankton equivalents]

@mnlevy1981 mnlevy1981 added this to the MARBL1.0.0 milestone Sep 7, 2018
@mnlevy1981 mnlevy1981 self-assigned this Sep 7, 2018
@mnlevy1981
Copy link
Collaborator Author

To go along with the changes from autotroph_type -> autotroph_settings_type and zooplankton_type -> zooplankton_settings_type, I also changed grazing_type -> grazer_settings_type. This also led to variable name changes:

  • autotrophs -> autotroph_settings
  • zooplankton -> zooplankton_settings
  • grazing -> grazer_settings

These changes propagate through the settings YAML files, MARBL python scripts, and POP wrappers to the MARBL python scripts (but don't change answers).

@mnlevy1981
Copy link
Collaborator Author

Rather than grazer_settings, I ended up renaming grazing to grazing_relationship_settings. This issue is addressed in marbl0.33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant