geometry add interactive #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
谢谢！基本没问题了，不过还有两个小修改麻烦修改一下： 有三个lint错误需要修改一下： 你可以在本地用npm run lint来验证。 另外isInteractive和setInteractive方法有点多余，可以删掉，options的设置可以直接用: geometry.config('interactive', false);这样可以和其他属性如editable等保持一致 |
|
好的。我调整下，然后重新提交下 |
|
isInteractive 是获取判断用的。这个得有个吧。我是看你的判断有个isVisible 我才加的 |
|
ok，isInteractive可以保留。👍 |
alex2wong
pushed a commit
to alex2wong/maptalks.js
that referenced
this pull request
Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geometry add interactive