Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorLayer support progressive Render #2169

Merged
merged 18 commits into from
Jan 10, 2024

Conversation

deyihu
Copy link
Collaborator

@deyihu deyihu commented Dec 25, 2023

fix #2171

fix #2177

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (19e44b9) 83.53% compared to head (cabf741) 83.18%.
Report is 1 commits behind head on master.

Files Patch % Lines
...rer/layer/vectorlayer/VectorLayerCanvasRenderer.js 48.96% 74 Missing ⚠️
src/layer/VectorLayer.js 60.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
- Coverage   83.53%   83.18%   -0.36%     
==========================================
  Files         171      171              
  Lines       18912    19059     +147     
==========================================
+ Hits        15799    15855      +56     
- Misses       3113     3204      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -501,6 +550,164 @@ class VectorLayerRenderer extends OverlayLayerCanvasRenderer {
_constructorIsThis() {
return this.constructor === VectorLayerRenderer;
}

_alwaysDraw() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以删除这个方法,改在isBlank中判断如果是progressiveRender则返回false

@fuzhenn fuzhenn merged commit 90ad2be into maptalks:master Jan 10, 2024
1 check passed
@deyihu deyihu deleted the progressiveRender branch January 10, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeometryCollection hitTolerance always is 0 VectorLayer support progressive Render
3 participants