Fix linking pybindings on Mac

Mac has different linker defaults than linux, and by default it does not allow undefined symbols to be left in resulting pybinding library. To allow it, we specifically pass linker argument when linking final pybinding object. This is done to avoid linking excessively to libpythonX.Y since at the time pybinding is loaded into Python process, all libpython symbols would be immediately available.
mapsme · Sep 30, 2020 · 4122b00 · 4122b00
1 parent 5b94691
commit 4122b00
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 2 deletions.
diff --git a/generator/mwm_diff/pymwm_diff/CMakeLists.txt b/generator/mwm_diff/pymwm_diff/CMakeLists.txt
@@ -22,4 +22,8 @@ omim_link_libraries(
   ${LIBZ}
 )
 
+if (PLATFORM_MAC)
+  omim_link_libraries(${PROJECT_NAME} "-Wl,-undefined,dynamic_lookup")
+endif()
+
 set_target_properties(${PROJECT_NAME} PROPERTIES PREFIX "")
diff --git a/generator/pygen/CMakeLists.txt b/generator/pygen/CMakeLists.txt
@@ -50,4 +50,8 @@ omim_link_libraries(
 link_qt5_core(${PROJECT_NAME})
 link_qt5_network(${PROJECT_NAME})
 
+if (PLATFORM_MAC)
+  omim_link_libraries(${PROJECT_NAME} "-Wl,-undefined,dynamic_lookup")
+endif()
+
 set_target_properties(${PROJECT_NAME} PROPERTIES PREFIX "")
diff --git a/kml/pykmlib/CMakeLists.txt b/kml/pykmlib/CMakeLists.txt
@@ -32,7 +32,7 @@ omim_link_libraries(
 link_qt5_core(${PROJECT_NAME})
 
 if (PLATFORM_MAC)
-  omim_link_libraries(${PROJECT_NAME} ${LIBZ})
+  omim_link_libraries(${PROJECT_NAME} "-Wl,-undefined,dynamic_lookup")
 endif()
 
 set_target_properties(${PROJECT_NAME} PROPERTIES PREFIX "")
diff --git a/local_ads/pylocal_ads/CMakeLists.txt b/local_ads/pylocal_ads/CMakeLists.txt
@@ -16,4 +16,8 @@ omim_link_libraries(
   base
 )
 
+if (PLATFORM_MAC)
+  omim_link_libraries(${PROJECT_NAME} "-Wl,-undefined,dynamic_lookup")
+endif()
+
 set_target_properties(${PROJECT_NAME} PROPERTIES PREFIX "")
diff --git a/search/pysearch/CMakeLists.txt b/search/pysearch/CMakeLists.txt
@@ -39,4 +39,8 @@ omim_link_libraries(
 link_qt5_core(${PROJECT_NAME})
 link_qt5_network(${PROJECT_NAME})
 
+if (PLATFORM_MAC)
+  omim_link_libraries(${PROJECT_NAME} "-Wl,-undefined,dynamic_lookup")
+endif()
+
 set_target_properties(${PROJECT_NAME} PROPERTIES PREFIX "")
diff --git a/tracking/pytracking/CMakeLists.txt b/tracking/pytracking/CMakeLists.txt
@@ -9,5 +9,17 @@ include_directories(${CMAKE_BINARY_DIR})
 
 omim_add_library(${PROJECT_NAME} MODULE ${SRC})
 
-omim_link_libraries(${PROJECT_NAME} ${Boost_LIBRARIES} tracking coding geometry base)
+omim_link_libraries(
+    ${PROJECT_NAME} 
+    ${Boost_LIBRARIES}
+    tracking
+    coding
+    geometry
+    base
+)
+
+if (PLATFORM_MAC)
+    omim_link_libraries(${PROJECT_NAME} "-Wl,-undefined,dynamic_lookup")
+endif()
+
 set_target_properties(${PROJECT_NAME} PROPERTIES PREFIX "")
diff --git a/traffic/pytraffic/CMakeLists.txt b/traffic/pytraffic/CMakeLists.txt
@@ -14,6 +14,7 @@ if (PLATFORM_MAC)
     ${PROJECT_NAME}
     ${Qt5Widgets_LIBRARIES}
     "-framework QuartzCore"
+    "-Wl,-undefined,dynamic_lookup"
   )
 endif()