Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for MapLibre Native Android 11.0.0 #104

Closed
louwers opened this issue Feb 28, 2024 · 7 comments · Fixed by #110
Closed

Update for MapLibre Native Android 11.0.0 #104

louwers opened this issue Feb 28, 2024 · 7 comments · Fixed by #110
Assignees

Comments

@louwers
Copy link

louwers commented Feb 28, 2024

MapLibre Native Android 11.0.0 has different import paths. Does anyone volunteer to update this package?

@Fabi755
Copy link
Collaborator

Fabi755 commented Feb 28, 2024

When we doing this, we should thinking about to upgrade our package names as well.

What do you think @boldtrn?

@boldtrn
Copy link
Collaborator

boldtrn commented Feb 29, 2024

Yes I think we should update our naming as well. Both for classes as well as packages 👍

@Fabi755
Copy link
Collaborator

Fabi755 commented Feb 29, 2024

I will finish the route eating this or next week. After that I will continue with this task.

@Fabi755 Fabi755 self-assigned this Feb 29, 2024
@boldtrn
Copy link
Collaborator

boldtrn commented Mar 18, 2024

It might be a good idea to do this in two steps. First update to the latest 10.X and create a release for this. Then we update to 11 and create a major release with breaking changes.

Android 11 requires OpenGL 3 which not everyone wants. To overhead for the additional release should be rather minimal as I don't think there were a lot of serious changes in the 10.X release.

@nitrag
Copy link

nitrag commented Jun 3, 2024

Hi, what's the status on this?

@Fabi755
Copy link
Collaborator

Fabi755 commented Jun 4, 2024

The other ticket takes too long, I will prefer this change here.

Android 11 requires OpenGL 3 which not everyone wants. To overhead for the additional release should be rather minimal as I don't think there were a lot of serious changes in the 10.X release.

I see that the native repository also have an legacy 10.x.x branch. I think we should also do that, to support fixes of the native library?!

@boldtrn
Copy link
Collaborator

boldtrn commented Jun 4, 2024

Yes I would propose that we first update to the latest version 10.x.x and do a release, then we do another breaking release with v11.

This was referenced Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants