Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing com.mapbox replacement on annotation layer ID #2498

Closed
Fabi755 opened this issue Jun 12, 2024 · 2 comments · Fixed by #2505
Closed

Missing com.mapbox replacement on annotation layer ID #2498

Fabi755 opened this issue Jun 12, 2024 · 2 comments · Fixed by #2505
Labels
android bug Something isn't working

Comments

@Fabi755
Copy link

Fabi755 commented Jun 12, 2024

Is there a reason why the MapLibreConstants.LAYER_ID_ANNOTATIONS is always com.mapbox.annotation.points and not migrated to org.maplibre.annotations.points.

Is see that the native code has already migrated to MapLibre naming. For example the AnnotationManager

By migrating the navigation SDK to v11, I have some issue with the layer order, and I'm not sure if this is the cause of this.

@Fabi755
Copy link
Author

Fabi755 commented Jun 12, 2024

I see there are still a lot of other constant values that contains the mapbox naming. Is this not converted yet in the full Java code?

@louwers louwers added bug Something isn't working android labels Jun 13, 2024
@louwers
Copy link
Collaborator

louwers commented Jun 13, 2024

Looks like it could be problematic. Thanks for reporting.

However, this change was not released yet. 11.0.0 is not affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants