Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ocean stripes over continent #4799

Open
wipfli opened this issue Oct 3, 2024 · 5 comments · May be fixed by #4868
Open

Ocean stripes over continent #4799

wipfli opened this issue Oct 3, 2024 · 5 comments · May be fixed by #4868
Assignees
@kubapelc
Labels
bug Something isn't working Globe Globe related issues PR is more than welcomed Extra attention is needed

Comments

@wipfli
Copy link
Contributor

wipfli commented Oct 3, 2024 •
edited
Loading

maplibre-gl-js version:
5.0.0-pre.1

browser:
chrome on ubuntu

Steps to Trigger Behavior

  1. Open https://jsbin.com/rulalux/edit?html,output
  2. observe stripes of ocean blue over continent

Link to Demonstration

5.0.0-pre.1

bug present:

https://jsbin.com/rulalux/edit?html,output

image

4.7.1

bug not prensent

https://jsbin.com/kiqetew/edit?html,output

image

Expected Behavior

no stripes like in v4

Actual Behavior

stripes
@wipfli
Copy link
Contributor Author

wipfli commented Oct 3, 2024

The stripes are also visible in the globe mode.

@HarelM HarelM added bug Something isn't working PR is more than welcomed Extra attention is needed labels Oct 3, 2024
@HarelM
Copy link
Collaborator

HarelM commented Oct 3, 2024

Thanks for taking the time to report this!
Can you try and make a smaller reproduction to narrow down the relevant layer?

@HarelM HarelM added the need more info Further information is requested label Oct 3, 2024
@wipfli
Copy link
Contributor Author

wipfli commented Oct 5, 2024

Updated the map style to have only one layer

@HarelM HarelM added Globe Globe related issues and removed need more info Further information is requested labels Oct 5, 2024
@kubapelc kubapelc self-assigned this Oct 16, 2024
@kubapelc
Copy link
Collaborator

I've been debugging this and I now believe this issue is the same as #4803

The map below is displaying only a single tile (1/1/1 - bottom right tile of zoom 1) of the source and only a single feature (id 2367) from it. Note that the stripes extend beyond the equator. The stripe geometry should normally not be visible, since it is beyond tile extents.

@HarelM
Copy link
Collaborator

HarelM commented Oct 17, 2024

Let's keep this one open for now, if it's the same root cause then a PR to solve it can close the other issue as well.
Thanks for looking into this!

@kubapelc kubapelc linked a pull request Oct 21, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kubapelc kubapelc

Labels
bug Something isn't working Globe Globe related issues PR is more than welcomed Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Globe: Tile borders fix windycom/maplibre-gl-js
3 participants
@HarelM @wipfli @kubapelc