Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain "hole" rendered when terrain tiles are missing #4859

Open
NathanMOlson opened this issue Oct 19, 2024 · 4 comments
Open

Terrain "hole" rendered when terrain tiles are missing #4859

NathanMOlson opened this issue Oct 19, 2024 · 4 comments
Labels
need more info Further information is requested

Comments

@NathanMOlson
Copy link
Contributor

NathanMOlson commented Oct 19, 2024

This issue appears in the terrain/fog render test. A hole appears in the rendered image.

Expected:
expected

Actual:
actual

Actual (drawn over a red background to demonstrate the transparent "hole" near the horizon):
actual_red_background

@HarelM
Copy link
Collaborator

HarelM commented Oct 20, 2024

All terrain tiles have a border to prevent holes in the terrain, see:

But for missing tiles I don't know what the behavior is.

Can you clarify the issue here, I'm not sure I understand the problem statement.

@HarelM HarelM added the need more info Further information is requested label Oct 20, 2024
@NathanMOlson
Copy link
Contributor Author

Sure. I've removed my thoughts about what is causing this so the problem statement is more clear, and added a separate issue for the problem with render test infrastructure: #4862

@ibesora
Copy link
Collaborator

ibesora commented Oct 21, 2024

What are your expectations on this? AFAIK, there's no hole it's just that it's getting rendered as if there were no elevation

@NathanMOlson
Copy link
Contributor Author

My expectation is that there is never a hole in the map, even when terrain tiles neighbor missing terrain tiles. I expect the behavior to match the 3D terrain demo, which doesn't have holes at the edge of valid terrain.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need more info Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants