-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove watch
scripts from package.json
#445
Comments
Does this mean that the watch-* scripts are no longer necessary to automatically trigger rebuilds or that we will no longer have this feature? |
I think that watch-* are just not working properly right now. I think it might be possible to bring them back, but it need some effort. |
The idea is to remove the watch functionality. |
Just for the record, I think the watch functionality is really useful for developing and it would be quite a loss to have to restart the server or manually build after every change. I assume restarting the server would not be necessary though? |
For development the watch functionality is very useful but at the moment it seems that the 'build' folder is watched, not the 'src' folder which seems strange as I would expect changes to be made to files in 'src'. |
It's useful but broken. Feel free to submit a PR to fix this. |
I have a branch that fixes the |
Types directory were removed, weren't they? |
Then it will be easier! |
I created the PR: #704. |
Fixed by #704 |
Is it possible/easy to also resurrect and fix watch-benchmarks and use the watch scripts in start-bench? This way we would have the full original functionality back. |
I can look into this if you want, unless you already started, in that case, let me know if you need some help. |
@jazzzz it would be great if you can look into this. I did nothing yet as i don't know the involved tools very well. |
|
Thank you very much! |
In the benchmark migration we came across a bunch of scripts in
package.json
which are broken or not used anymore. We might want to remove all scripts of the formwatch-*
and clean up historic CI-related scripts that are now replaced with GitHub Actions likeprepublishOnly
,print-release-url
, anddiff-tarball
.The text was updated successfully, but these errors were encountered: