Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove watch scripts from package.json #445

Closed
wipfli opened this issue Oct 6, 2021 · 17 comments
Closed

Remove watch scripts from package.json #445

wipfli opened this issue Oct 6, 2021 · 17 comments

Comments

@wipfli
Copy link
Contributor

wipfli commented Oct 6, 2021

In the benchmark migration we came across a bunch of scripts in package.json which are broken or not used anymore. We might want to remove all scripts of the form watch-* and clean up historic CI-related scripts that are now replaced with GitHub Actions like prepublishOnly, print-release-url, and diff-tarball.

@xabbu42
Copy link
Contributor

xabbu42 commented Oct 6, 2021

Does this mean that the watch-* scripts are no longer necessary to automatically trigger rebuilds or that we will no longer have this feature?

@HarelM
Copy link
Collaborator

HarelM commented Oct 6, 2021

I think that watch-* are just not working properly right now. I think it might be possible to bring them back, but it need some effort.

@wipfli
Copy link
Contributor Author

wipfli commented Oct 9, 2021

The idea is to remove the watch functionality.

@xabbu42
Copy link
Contributor

xabbu42 commented Oct 13, 2021

Just for the record, I think the watch functionality is really useful for developing and it would be quite a loss to have to restart the server or manually build after every change. I assume restarting the server would not be necessary though?

@jaapster
Copy link

jaapster commented Dec 7, 2021

For development the watch functionality is very useful but at the moment it seems that the 'build' folder is watched, not the 'src' folder which seems strange as I would expect changes to be made to files in 'src'.
Is that on purpose?

@HarelM
Copy link
Collaborator

HarelM commented Dec 7, 2021

It's useful but broken. Feel free to submit a PR to fix this.

@jazzzz
Copy link
Contributor

jazzzz commented Dec 7, 2021

I have a branch that fixes the watch scripts, I intend to make a PR but I still need to fix some things, mostly moving back the types directory to the root directory.

@HarelM
Copy link
Collaborator

HarelM commented Dec 7, 2021

Types directory were removed, weren't they?

@jazzzz
Copy link
Contributor

jazzzz commented Dec 7, 2021

Types directory were removed, weren't they?

Then it will be easier!

@jazzzz
Copy link
Contributor

jazzzz commented Dec 10, 2021

I created the PR: #704.

@HarelM
Copy link
Collaborator

HarelM commented Dec 21, 2021

Fixed by #704

@HarelM HarelM closed this as completed Dec 21, 2021
@xabbu42
Copy link
Contributor

xabbu42 commented Dec 28, 2021

Is it possible/easy to also resurrect and fix watch-benchmarks and use the watch scripts in start-bench? This way we would have the full original functionality back.

@HarelM
Copy link
Collaborator

HarelM commented Dec 28, 2021

@xabbu42 feel free to pursue this :-) Maybe @jazzzz can help out as well.

@jazzzz
Copy link
Contributor

jazzzz commented Jan 3, 2022

Is it possible/easy to also resurrect and fix watch-benchmarks and use the watch scripts in start-bench? This way we would have the full original functionality back.

I can look into this if you want, unless you already started, in that case, let me know if you need some help.

@xabbu42
Copy link
Contributor

xabbu42 commented Jan 3, 2022

@jazzzz it would be great if you can look into this. I did nothing yet as i don't know the involved tools very well.

@jazzzz
Copy link
Contributor

jazzzz commented Jan 3, 2022

Is it possible/easy to also resurrect and fix watch-benchmarks and use the watch scripts in start-bench? This way we would have the full original functionality back.

#754

@xabbu42
Copy link
Contributor

xabbu42 commented Jan 4, 2022

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants