Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: -ms-high-contrast is in the process of being deprecated #4193

Closed
coliff opened this issue May 29, 2024 · 1 comment · Fixed by #4250
Closed

CSS: -ms-high-contrast is in the process of being deprecated #4193

coliff opened this issue May 29, 2024 · 1 comment · Fixed by #4250
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed
Milestone

Comments

@coliff
Copy link
Contributor

coliff commented May 29, 2024

maplibre-gl-js version: Current

browser: Edge v125 (Windows 11)

Link to Demonstration

Visit this page with Edge:
https://maplibre.org/maplibre-gl-js/docs/examples/3d-terrain/

Open Devtools Console and observe the warning:
image

Expected Behavior

Instead of using the old, deprecated -ms-high-contrast could consider switching to the more universally accepted prefers-contrast media query.

info:

@HarelM
Copy link
Collaborator

HarelM commented May 29, 2024

I think this is a good approach, but I would recommend changing it as part of a breaking change version (#3834) as this is a css change that may affect some users.

@HarelM HarelM added the enhancement New feature or request label May 29, 2024
@HarelM HarelM added this to the 5.0 milestone May 29, 2024
@HarelM HarelM added the PR is more than welcomed Extra attention is needed label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants