Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI on Windows hosts #39

Closed
nyurik opened this issue Dec 15, 2020 · 1 comment · Fixed by #42
Closed

Enable CI on Windows hosts #39

nyurik opened this issue Dec 15, 2020 · 1 comment · Fixed by #42

Comments

@nyurik
Copy link
Member

nyurik commented Dec 15, 2020

Following up to #4, need to set up automated Windows testing. CC: @msbarry

@msbarry
Copy link
Contributor

msbarry commented Dec 16, 2020

Looking at the existing config from .circleci/config.yml I see these steps that I don't think would be too hard to convert to github actions:

  • lint (lint, lint-docs, lint-css)
  • build (build-prod, build-prod-min, ... test-build)
  • check-size
  • collect-stats (node bench/gl-stats.js)
  • test-flow
  • test-unit
  • test-render (yarn run test-render then upload artifacts)
  • test-query (yarn test-query then upload artifacts)
  • test-browser (depends on selenium and a headless browser being present)
  • test-expressions

Do you think we should try to get all of them running on windows, mac, and ubuntu? Or try to have ubuntu do all of those, and mac/windows do a subset (ie. just lint, build, and tests)? Concretely I was running into trouble with flow on windows and found that flow isn't fully supported on windows so it might not be feasible to support the whole pipeline on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants