You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An empty benchmark graph appears and the benchmark starts executing. No errors in console.
Actual Behavior
Empty page with errors in the console.
On firefox:
TypeError: can't convert undefined to object
runComparison http://localhost:9966/test/bench/versions/index.html#Layout:33
On Chrome:
Failed to load resource: net::ERR_UNKNOWN_URL_SCHEME
index.html:69 TypeError: Cannot convert undefined or null to object
at Function.keys (<anonymous>)
at runComparison (index.html:33:50)
Notes
I've tried to binary search for the commit that broke this, and the first commit with broken benchmarks is 15afd542, which is a merge of #3601
The text was updated successfully, but these errors were encountered:
kubapelc
changed the title
Benchmarks are broken
Benchmarks are broken: window.maplibreglBenchmarks is undefined
Mar 25, 2024
Bummer, I should've ran the benchmarks to see that they still run after this commit.
Thanks for the update!
Let me know if you prefer to let me handle this or open a PR to solve this.
I prefer to let you handle it, I have no idea what might be causing this or how to fix it. I would try to binary search the commits of the PR to see what actually caused the benchmarks to break and look for clues there, but that branch doesn't seem to be around anymore.
The changes there are minimal in terms of code, it's more about how maplibre is packed and exposed. Since the benchmark are also packing maplibre in a different way I can imagine why this broke, but I'll still need to find where to fix it.
It might take a few days though...
maplibre-gl-js version: v4.0.0-pre5, and any newer version up to current v4.1.1
browser: Firefox 115.9.1esr, Chrome 122.0.6261.131
Steps to Trigger Behavior
npm run start-bench
Expected Behavior
An empty benchmark graph appears and the benchmark starts executing. No errors in console.
Actual Behavior
Empty page with errors in the console.
On firefox:
On Chrome:
Notes
I've tried to binary search for the commit that broke this, and the first commit with broken benchmarks is 15afd542, which is a merge of #3601
The text was updated successfully, but these errors were encountered: