Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geolocate_control.ts Some events are missing #3846

Closed
mrajaei76 opened this issue Mar 17, 2024 · 1 comment · Fixed by #3847
Closed

geolocate_control.ts Some events are missing #3846

mrajaei76 opened this issue Mar 17, 2024 · 1 comment · Fixed by #3847
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed

Comments

@mrajaei76
Copy link
Contributor

User Story

I was creating a custom button for geolocation, utilizing the events thrown by the Geolocate class. I noticed that the Geolocate class has six states in _watchState, but it doesn't emit events for each of these states.

The states and their corresponding events are as follows:

WAITING_ACTIVE: trackuserlocationstart
ACTIVE_LOCK: geolocate
OFF: trackuserlocationend
BACKGROUND: trackuserlocationend
BACKGROUND_ERROR: error
ACTIVE_ERROR: error

However, I'm unable to distinguish when the Geolocator turns off or when the user drags the map, among other actions, due to the lack of specific events for each state.

Rationale

This limitation prevents me from fully customizing the button and handling related events accurately.

Impact

I can submit a pull request to address this issue if desired.

@HarelM
Copy link
Collaborator

HarelM commented Mar 17, 2024

A PR would be great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed
Projects
None yet
2 participants