Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to trigger a (synchronous) redraw #206

Closed
pakb opened this issue Jul 12, 2021 · 3 comments
Closed

Add a way to trigger a (synchronous) redraw #206

pakb opened this issue Jul 12, 2021 · 3 comments

Comments

@pakb
Copy link

pakb commented Jul 12, 2021

Motivation

As stated in this Mapbox's issue some of us would like to have a way to trigger a redraw when we see it fit.
An exemple would be to use a Maplibre instance under another framework (i.e. Openlayers) and we want this master framework to be responsible of interpolating different WMS/WMTS layers with different CRS together, where Maplibre is here to render background vector tiles.
In this case, if we move the map, the two framework do not sync their redraw. This can result in "laggy" panning / zooming.

A solution that was proposed by the Openlayers community back then was to use some internal API function of Mapbox (see this example on openlayers.org)

This would clearly ease the integration of Maplibre in different frameworks (either mapping or UI, the issue on Mapbox's repo was more about React than Openlayers).

@HarelM
Copy link
Collaborator

HarelM commented Jul 12, 2021

The best approach would be to send a PR with tests included. If exposing such a simple method is the solution I'm all for it.

@lseelenbinder
Copy link
Member

I think this is an excellent idea, and I'm agreed with @HarelM that with a PR, we should be able to merge without much difficulty.

@snickell
Copy link
Contributor

Total agreement with @HarelM from me too, very happy to do review on this feature.... at least I would be this week haha. But I really support any efforts to add minimal hooks to avoid jenk and tear, I think that's exactly the find of polish I'd like to see going forward, neat project @pakb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants