Fixed a bug with leading whitespaces in WKT #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress on getting this merged in? I just ran into the issue in a class that I'm teaching. (/cc @throberto) |
mjumbewu
added a commit
to musa-5090-spring-2024/course-info
that referenced
this pull request
Feb 28, 2024
- Create a JS function for parsing WKT points because ALL THE LIBRARIES DO IT WRONG (see mapbox/wellknown#42) - Use the ESRI proj codes library, because Proj4JS only comes with 4326, 4265, and 3857 predefined - Speed up the Python script A LOT by using the non-deprecated pyproj workflow
this repository has not been updated for a long time... we have a successor for it (https://github.com/placemark/betterknown) maybe this problem has already been fixed there hey @tmcw 😄 |
|
betterknown tolerates leading whitespace. And, y'all are probably aware, but I don't have commit for this repo because I haven't worked for Mapbox in a half-decade :) |
|
Awesome, thanks for the heads up about betterknown @throberto @tmcw ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Not sure if this package gets updated too often anymore, but here's my 2 cents for fixing #36 which we've been running into recently.
Seems that the bug was caused by a missing
white()call in the beginning ofcoords()- confirmed that everything still seems to work in unit tests after the fix.Here's the list of changes:
white()call to fix Parser does not parse wkt's with whitespace after first '(' #36browserifytodevDependenciesto makenpm installwork without global installationswellknown.js- seems that the version previously used was somewhere between 9.0.0 and 11.2.0 (chose the latest)