Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: make wagyu container neutral #103

Open
bylee20 opened this issue Dec 20, 2019 · 1 comment
Open

Feature Request: make wagyu container neutral #103

bylee20 opened this issue Dec 20, 2019 · 1 comment

Comments

@bylee20
Copy link

bylee20 commented Dec 20, 2019

mapbox::geometry class templates are container neutral, that is, I can set container type as second template argument.

On the other hand, all geometry types in wagyu uses default argument which is std::vector.
It would be nice for wagyu to support arbitary container just like that mapbox::geometry does.

@flippmoke
Copy link
Member

Yes this was something I really wanted to do in general, but I never got around to getting it done. This likely involve a large number of templating and a requirement for the user to create accessors methods of doing operations on their general geometry object.

I vaguely recall part of the reason I did this was to make it easier to copy out results and I used the geometry.hpp for internal calculations. I think all of this could easily be accomplished, but not planning right now to do this work due to personal limitations on time. I would happily support any PR on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants