-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document vector_layers extension #14
Comments
Bumping this. Happy to put in a PR if yall agree/confirm that this should happen. Assuming yes, my understanding is that the schema for "vector_layers": {
"type": "array",
"items": {
"type": "object",
"properties": {
"id": { "type": "string" }
"description": { "type": "string" },
"fields": { "type": "object" }
"required": [ "id", "fields" ]
}
}
} And the |
I recently got stung by this when trying to use tessera which uses tilelive to serve up a tmstyle. If you have no It would be helpful if the spec included this. |
ping on this. I could also do a PR if there's agreement and understanding on what the schema is (though if @anandthakker already has something written, I'd prefer that) |
@pnorman Nothing written, alas. Still willing to do it, but my queue is somewhat longer today than it was when I last commented here. |
It seems like the only property that mapbox-gl-js currently uses is the Reviewing the source it looks like if that field is not present, and does not map to the layerId in the vector tile, then nothing will render. |
I'm currently implementing the TileJSON spec for an MVT server and would also like to see an agreed upon spec for the
Here's the spec I'm proposing:
Looking forward to the discussion. |
|
Here's an additional proposal we can pick apart:
|
Some further info from experimenting: Mapbox Studio expects the |
@gmaclennan can you provide an example? I wonder how set in stone the Mapbox implementation is? They might have just made some decisions expecting for the spec to drive some changes in the future. |
I'm still 👎 on including the format as a property of the vector_layers object. We should use I'd like to see vector_layers contain a list of layers, each layer with a |
Sorry for insisting but e.g. #29 is closed just because it's referring to this overdue open issue. Allow me to make an understatement: The lack of support from Mapbox of the TileJSON and the mbtiles specs. for vector tiles contrasts IMHO little bit to its PR activities and $164 million funding. Can someone from Mapbox tell us who is the maintainer of this mentioned specs.? IMHO many metadata discussions could be much more efficient if specs. would be updated. See currently openmaptiles/openmaptiles#379 (comment) , or geometalab/Vector-Tiles-Reader-QGIS-Plugin#170 , or systemed/tilemaker#102 . Recently hope was raising since there's a pull request for mbtiles v1.3 mapbox/mbtiles-spec#46 (comment) . This hope was put in question when @flippmoke wrote:
and @pnorman answered
This frustration is the same reason for me hesitating to contribute. But I just don't want to give up yet! |
Sorry for the long delay on spec revisions @sfkeller. I think mapbox/mbtiles-spec#47 is ready to merge to describe the current reality. Please let me know if you have any significant objections to what is there. |
@ericfischer : Thanks. We're reviewing the spec revision now. It's really not just me waiting for this update (also of TileJSON) it's for the sake of innovation based on established standards, see e.g. this from @tomchadwin https://twitter.com/tomchadwin/status/958646784439607296 . |
I'm glad to see mbtiles 1.3 released! https://github.com/mapbox/mbtiles-spec |
Hey y'all, thanks for the back-and-forth here. Our plan is to include vector_layers in the next version of the specification (version 3). Since this key is clearly being used in Mapbox and other implementations, it needs to be documented. @GretaCB and myself will comment back here as we start drafting the next version. |
Per discussion with @ericfischer - the current plan in documenting the structure of vector_layers is to take the text from the mbtiles spec and move it into this specification as a source of truth, therefore the mbtiles-specification can point directly to version 3.0 here, rather than documenting the same thing in two places. |
We're starting to see a lot of tilejson with a vector_layers key. We should document this for standardization and so that the meaning the keys are documented.
Some examples
https://gist.github.com/springmeyer/bbf49c89180485f477b9
https://github.com/mapbox/mapbox-studio/blob/mb-pages/test/fixtures-mapboxapi/mapbox.mapbox-streets-v5.json
Edit: fixed link
The text was updated successfully, but these errors were encountered: