Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Dependency @turf/isolines has changed its API so version needs to be fixed #31

Closed
mvl22 opened this issue Nov 15, 2018 · 0 comments
Closed

Comments

@mvl22
Copy link

mvl22 commented Nov 15, 2018

The code calls isolines() at
https://github.com/mapbox/osrm-isochrone/blob/master/index.js#L20

However, that is using the pre-4.5.2 interface to @turf/isolines.

That interface was changed in:
Turfjs/turf@321d0df#diff-ba41233dbd590d55878b1d00a76de5b9
Turfjs/turf#781

Their example shows the difference:

- var isolined = turf.isolines(points, 'z', 15, breaks);
+ var isolines = turf.isolines(points, breaks, 'temperature');

So I think the version of @turf/isolines needs to be fixed as >=3.5.2 <4.5.2 at
https://github.com/mapbox/osrm-isochrone/blob/master/package.json#L32

or the calling code updated to the newer call format.

Subsequently the third parameter has been changed to an object, so is now set as the options.zProperty parameter:
https://github.com/Turfjs/turf/tree/master/packages/turf-isolines#isolines

@guptabless guptabless closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants