Added json1 support note #1303
Merged
Added json1 support note #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is kind of an insignificantly small PR, but I can't tell you how long it took me to finally look at the code and see that the support was already there. I'm assuming I'm not the only one. |
|
Thank you @everyplace, great contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a single mention to the bundled extension in the README.md file, to help surface this important feature inclusion, in hopes of saving others the time and anguish it took me to figure it out.
Per PR 538, support for the json1 extension has been bundled in the npm distribution since late 2015. However, this feature isn't surfaced anywhere in the documentation, or the wiki, and the only way to discover it is via reading the build configs or searching the closed PRs. Since json1 is the first extension listed in the official docs, it makes sense to mention this inclusion in the docs.
Alternatively, a "bundled extensions" wiki entry could be created to mention all of the bundled extensions.