Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to N-API #45

Closed
springmeyer opened this issue Jun 15, 2017 · 3 comments
Closed

Port to N-API #45

springmeyer opened this issue Jun 15, 2017 · 3 comments

Comments

@springmeyer
Copy link
Contributor

springmeyer commented Jun 15, 2017

A fun task would be to start a branch of skel that switches NAN for N-API.

This branch would:

  • Drop support for node versions (in the travis.yml) that don't support N-API
  • Drop usage of NAN

The goal of this branch would be:

  • Help us learn about N-API
  • Help provide simple examples of N-API usage for the time when we want to (potentially) move all modules to it.
  • Learn what we don't know we need to learn about N-API (this is probably the most important one)

Caveat: The reality is that skel will need to support older node versions for a while, so this branch would need to stay in a branch and might drift/get out of date. And it would naturally have tons of conflicts with master.

@springmeyer
Copy link
Contributor Author

This remains relevant and important to learn about. I'm adding this to my list of things to look into. My plan is to find 30 minutes to experiment. I will create a branch and try porting things over and see how far I can get. /cc @GretaCB

@springmeyer
Copy link
Contributor Author

With the release of node 10 this week (https://nodejs.org/en/blog/release/v10.0.0/), N-API is now no longer experimental (mapbox/node-pre-gyp#345 was key to getting "out of experimental status") so this means:

  • @mapbox/core-tech should plan to port all our modules to N-API
  • the first step I think should be to port node-cpp-skel to N-API

@springmeyer
Copy link
Contributor Author

done in #161 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant