We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The CFI build is failing with:
# success: prints expected string Illegal instruction (core dumped)
https://travis-ci.com/github/mapbox/node-cpp-skel/jobs/455213147#L449
I wonder if this started at 0f679d2? @artemp can you take a look?
The text was updated successfully, but these errors were encountered:
The issue is cfi sanitizer doesn't like CRTP pattern cast here: https://github.com/nodejs/node-addon-api/blob/master/napi-inl.h#L3545
Process 27867 launched: '/opt/node/bin/node' (x86_64) TAP version 13 # success: prints expected string Process 27867 stopped * thread #1, name = 'node', stop reason = signal SIGILL: illegal instruction operand frame #0: 0x00007ffff52271c2 module.node`Napi::ObjectWrap<object_sync::HelloObject>::ObjectWrap(this=0x00005555577d10c0, callbackInfo=0x00007fffffffc1a8) at napi-inl.h:3545:17 3542 napi_value wrapper = callbackInfo.This(); 3543 napi_status status; 3544 napi_ref ref; -> 3545 T* instance = static_cast<T*>(this); <===================== FAIL 3546 status = napi_wrap(env, wrapper, instance, FinalizeCallback, nullptr, &ref); 3547 NAPI_THROW_IF_FAILED_VOID(env, status); 3548
I'll submit PR with the fix (disabling cfi-derived-cast check for any functions which has 'ObjectWrap` string in its name.
cfi-derived-cast
Sorry, something went wrong.
Fixed in #167
No branches or pull requests
The CFI build is failing with:
https://travis-ci.com/github/mapbox/node-cpp-skel/jobs/455213147#L449
I wonder if this started at 0f679d2? @artemp can you take a look?
The text was updated successfully, but these errors were encountered: