You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We must protect against crashes like this, so I think its worth adding try/catch around the code in node-cpp-skel. Then users would be forced (due to the lack of coverage of the catch to think hard about whether an exception is possible.
The text was updated successfully, but these errors were encountered:
We should add try/catch around code in the HandleOKCallback like
node-cpp-skel/src/object_async/hello_async.cpp
Lines 179 to 186 in c3d13e7
abort
An example is mapbox/vtquery#69 /cc @mapsam
We must protect against crashes like this, so I think its worth adding try/catch around the code in node-cpp-skel. Then users would be forced (due to the lack of coverage of the
catch
to think hard about whether an exception is possible.The text was updated successfully, but these errors were encountered: