"Merge" icon still reversed

[ericrwolfe]

It looks like the merge icon is still reversed. This was a "merge left" maneuver but the icon shows merge right:

cc @frederoni

[frederoni]

This particular merge is a straight merge:

bearing_after:161
bearing_before:153
modifier:"straight"

so we end up not flipping the icon because it's not left, slight left, or sharp left.

Merge, take off ramp, and reach fork could use a different logic where the slightest difference in bearing should determine the direction.

[ericrwolfe]

For merge straight (or any straight modifiers) we should probably just show a straight arrow.

[1ec5]

When we say “merge left”, what that means is that there’s traffic coming in over the user’s left shoulder, not that the user needs to turn left at the maneuver. Since we aren’t having users literally fall off ramps into traffic below, there should be no such thing as a “straight merge”. This is almost certainly a regression in the Directions API. I’ve filed a bug report upstream in that project.

/ref Project-OSRM/osrm-text-instructions#183

[1ec5]

Fixed upstream, server-side, in Project-OSRM/osrm-backend#4670.