Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Swift linter to ensure code quality. #2937

Open
azarovalex opened this issue Apr 15, 2021 · 0 comments
Open

Use Swift linter to ensure code quality. #2937

azarovalex opened this issue Apr 15, 2021 · 0 comments
Labels
build Issues related to builds and dependency management. jira-sync-complete op-ex Refactoring, Tech Debt or any other operational excellence work.

Comments

@azarovalex
Copy link
Contributor

There is a company-wide discussion about lint usage in Swift code: https://github.com/mapbox/apple-internal/issues/20.

We've already encountered a couple of crashes because we didn't forbid the usage of force unwrapping and implicit optional. @1ec5 proposed to add a linter to warn about unsafe code here: mapbox/mapbox-directions-swift#453

In addition, sometimes I review PRs and come across trivial typos that a linter could have caught during the development. Adding a linter can help us here. An example of such a PR: mapbox/mapbox-navigation-ios-examples#89.

As a reference, Nikolay from 1Tap recently added a SwiftLint: https://github.com/mapbox/1tap-ios/pull/128

@azarovalex azarovalex added build Issues related to builds and dependency management. op-ex Refactoring, Tech Debt or any other operational excellence work. labels Apr 15, 2021
@azarovalex azarovalex self-assigned this Apr 15, 2021
@azarovalex azarovalex changed the title Use swift linter to ensure code quality. Use Swift linter to ensure code quality. Apr 15, 2021
@truburt truburt added this to the v2.1 (beta) milestone Sep 17, 2021
@1ec5 1ec5 modified the milestones: v2.1-beta, v2.2-beta Nov 11, 2021
@MaximAlien MaximAlien removed this from the v2.2-beta milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management. jira-sync-complete op-ex Refactoring, Tech Debt or any other operational excellence work.
Projects
None yet
Development

No branches or pull requests

4 participants