Use Swift linter to ensure code quality. #2937
Labels
build
Issues related to builds and dependency management.
jira-sync-complete
op-ex
Refactoring, Tech Debt or any other operational excellence work.
There is a company-wide discussion about lint usage in Swift code: https://github.com/mapbox/apple-internal/issues/20.
We've already encountered a couple of crashes because we didn't forbid the usage of force unwrapping and implicit optional. @1ec5 proposed to add a linter to warn about unsafe code here: mapbox/mapbox-directions-swift#453
In addition, sometimes I review PRs and come across trivial typos that a linter could have caught during the development. Adding a linter can help us here. An example of such a PR: mapbox/mapbox-navigation-ios-examples#89.
As a reference, Nikolay from 1Tap recently added a SwiftLint: https://github.com/mapbox/1tap-ios/pull/128
The text was updated successfully, but these errors were encountered: