-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deemphasize portions of the route line that the user has passed #892
Comments
No longer blocked by mapbox/mapbox-gl-native#11718, but potentially still blocked by mapbox/mapbox-gl-js#3170 if we need to animate the gradient using a paint property transition and need to refer to a feature property in the |
I don't think that animations or data-driven styling should be blockers. However, we should keep in mind that constant layer properties updates led to minor JNI impl issues in the past - mapbox/mapbox-plugins-android#362. We'd need to verify the stability. |
With latest changes adding support for vanishing route line feature, where are we here? Good to close @LukasPaczos @cafesilencio @abhishek1508? |
I think we're good to close. There are other tickets tracking the improvements that have been made. |
Portions of the route line that the user has already passed should be displayed in a more muted or translucent color, to better emphasize the portion that the user still has yet to reach. This effect would be most prominent in overview mode, but even in straight-ahead mode, the line would look different above and below the user puck.
The ideal implementation would keep the line’s geometry constant as the user moves, to maximize performance. Instead of changing the geometry, we’ll change the
LineLayer
’slineGradient
to abruptly go from translucent to opaque at the user’s location along the line, with a smooth transition (lineGradientTransition
) that matches the puck’s animated interpolation. Line gradients will be implemented in the map SDK for mapbox/mapbox-gl-native#11718./ref mapbox/mapbox-navigation-ios#1307
/cc @danesfeder
The text was updated successfully, but these errors were encountered: