Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access token from RouteOptions #1275

Closed
LukasPaczos opened this issue Jul 27, 2021 · 0 comments · Fixed by #1276
Closed

Remove access token from RouteOptions #1275

LukasPaczos opened this issue Jul 27, 2021 · 0 comments · Fixed by #1276
Assignees

Comments

@LukasPaczos
Copy link
Contributor

Refs #1265, #1267, and #1270 where we tightened the RouteOptions integration while also stopped serializing the access token for security reasons. In mapbox/mapbox-navigation-android#4662 (comment) we were discussing the implications and potential improvements.

We should be able to entirely remove the access token from the RouteOptions to avoid the problems of deserialization and usability of route objects. Each entity that does need to make a resources request using a route reference (like annotations refresh or reroute) will most likely get a token from a different source, the route object shouldn't need to transport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant