Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streets: Fluvial administrative boundaries look like roads #108

Closed
1ec5 opened this issue Apr 10, 2015 · 5 comments
Closed

Streets: Fluvial administrative boundaries look like roads #108

1ec5 opened this issue Apr 10, 2015 · 5 comments
Assignees

Comments

@1ec5
Copy link
Contributor

1ec5 commented Apr 10, 2015

Administrative boundaries have a translucent, grayish casing. It’s a good choice, but it blends in too easily with some landcover and ends up looking like a road or pier when the boundary runs over water. It’s obvious that it’s part of a boundary, but at middle zoom levels, it can make a river look like a series of disjointed lakes:

boundary1
boundary2
boundary3

The casing should be made more transparent. Ideally, the outer edges of the casing should fade away slightly.

@samanpwbb samanpwbb modified the milestone: Mapbox Streets GL Apr 10, 2015
@nickidlugash
Copy link
Contributor

@1ec5 ideally these would be more transparent, but we can't style them this way unless we have per-layer opacity, which is probably not going to happen soon. I'll investigate ways to improve this styling without opacity.

@1ec5
Copy link
Contributor Author

1ec5 commented Apr 15, 2015

A color operation could be helpful here (mapbox/mapbox-gl-style-spec#38). After all, the casing of an administrative boundary is essentially a halo. On the mapbox-gl-js side, color operations appear to have been implemented via mapbox/mapbox-gl-js#1158 and mapbox/color-ops. On the native front, there’s the https://github.com/mapbox/mapbox-gl-native/tree/color_operations branch.

@samanpwbb
Copy link
Contributor

I'd be interested in switching to black dashed line with semi-transparent white halo. Better contrast with roads, and just feels more understandable.

@nickidlugash
Copy link
Contributor

Black is too strong, and makes it more difficult to read text labels. I've made the line much more desaturated, and lighter. White is also too strong, since we can't implement light semi-transparencies well. I've added a line blur to the background layers, although I'm not sure what performance impact this has.

screen shot 2015-04-17 at 6 19 16 pm
screen shot 2015-04-17 at 6 27 41 pm

@samanpwbb
Copy link
Contributor

This is in better shape now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants