Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

Remove "*-ignore-placement" properties and expand the scope of "*-allow-overlap" properties #429

Closed
ansis opened this issue Mar 18, 2016 · 2 comments

Comments

@ansis
Copy link
Contributor

ansis commented Mar 18, 2016

There are currently two properties that affect how a symbol

  • -allow-overlap determines if previous symbols affect the placement of the current symbol
  • -ignore-placement determines if the current symbol will affect the placement of layer symbols

In most cases you want both to have the same value. I can't think of an example you would want them to be different.

We should remove -ignore-placement and make -allow-overlap do what both these properties currently do.

@nickidlugash @peterqliu can you imagine a case where you would want these two properties to be separate?

@nickidlugash
Copy link
Contributor

@ansis@peterqliu has probably touched upon more varied styling use cases, but personally I don't have any important use cases for having different values for these two properties. I'm a fan of reducing the number of arcane properties pertaining to label placement/behavior 👍

Not to open a can of worms, but this is what I actually want for collision properties (actual property names TBD):

  1. Allow overlap with symbols in other layers
  2. Allow overlap within symbols in current layer

I think the distinction between whether a symbol can overlap symbols within its own layer or with symbols in other layers is much more important for styling than the distinction between whether a symbol can overlap symbols in layers above or below the current layer. Since collision detection is per-feature, both our current properties essentially create identical behavior for symbols within the same layer (a true value for either makes symbols within a layer overlap each other). I think this has been the source of a lot of user confusion between the two properties. We have two properties to control overlapping symbols, but you still can't control what you actually want to control.

@lucaswoj lucaswoj changed the title removing -ignore-placement Remove "*-ignore-placement" properties and expand the scope of "*-allow-overlap" properties Dec 22, 2016
@lucaswoj
Copy link

lucaswoj commented Feb 1, 2017

This issue was moved to mapbox/mapbox-gl-js#4117

@lucaswoj lucaswoj closed this as completed Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants