Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Port fix for GL JS issue #5112 (line label rendering errors on overzoomed tiles) #9843

Closed
ChrisLoer opened this issue Aug 23, 2017 · 1 comment
Closed

Port fix for GL JS issue #5112 (line label rendering errors on overzoomed tiles) #9843

ChrisLoer opened this issue Aug 23, 2017 · 1 comment
Assignees
@ChrisLoer
Labels
bug Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS

Comments

@ChrisLoer
Copy link
Contributor

Port of mapbox/mapbox-gl-js#5120.

/cc @ansis @anandthakker @asheemmamoowala
@ChrisLoer ChrisLoer added bug GL JS parity For feature parity with Mapbox GL JS labels Aug 23, 2017
@ChrisLoer ChrisLoer self-assigned this Aug 23, 2017
ChrisLoer added a commit that referenced this issue Aug 23, 2017
@ChrisLoer
[test] Add ignores while waiting for fix to issue #9843.
55dd297
@kkaefer kkaefer added the Core The cross-platform C++ core, aka mbgl label Aug 25, 2017
ChrisLoer added a commit that referenced this issue Aug 25, 2017
@ChrisLoer
[core] Fix issue #9843 (overzoomed line label rendering glitch).
f71ccb6 
Ports fix for GL JS issue #5112.
Line label projection can't be based on tile geometry that's behind the plane of the camera.
The relevant tests are still ignored because the overzoomed collision behavior is different between native and JS.
@ChrisLoer ChrisLoer mentioned this issue Aug 25, 2017
Merged
ChrisLoer added a commit that referenced this issue Aug 25, 2017
@ChrisLoer
[core] Fix issue #9843 (overzoomed line label rendering glitch).
6cbeeff 
Ports fix for GL JS issue #5112.
Line label projection can't be based on tile geometry that's behind the plane of the camera.
The relevant tests are still ignored because the overzoomed collision behavior is different between native and JS.
@ChrisLoer
Copy link
Contributor Author

Fixed with #9865.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChrisLoer ChrisLoer

Labels
bug Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkaefer @ChrisLoer