Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLSphericalPosition.radial has misleading type #9234

Closed
1ec5 opened this issue Jun 9, 2017 · 1 comment
Closed

MGLSphericalPosition.radial has misleading type #9234

1ec5 opened this issue Jun 9, 2017 · 1 comment
Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone
ios-v3.6.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jun 9, 2017

MGLSphericalPosition.radial has the type CLLocationDistance, which is documented to be measured in meters. However, mbgl actually interprets radial to be measured in some sort of non-physical unit. It isn’t meters, but I’m not really sure what it is. We should change the type from CLLocationDistance to CGFloat to remove the misleading semantics.

/ref #9043 (comment)
/cc @lbud @fabian-guerra
@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels Jun 9, 2017
@1ec5 1ec5 added this to the ios-v3.6.0 milestone Jun 9, 2017
@1ec5 1ec5 mentioned this issue Jun 9, 2017
Merged
4 tasks
@fabian-guerra fabian-guerra mentioned this issue Jun 12, 2017
Merged
@fabian-guerra
Copy link
Contributor

Fixed in #9247

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Milestone
ios-v3.6.0
Development

No branches or pull requests
2 participants
@1ec5 @fabian-guerra