Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Non-required Android testing build #8372

Closed
tobrun opened this issue Mar 13, 2017 · 4 comments
Closed

Non-required Android testing build #8372

tobrun opened this issue Mar 13, 2017 · 4 comments
Assignees
Labels
Android Mapbox Maps SDK for Android tests

Comments

@tobrun
Copy link
Member

tobrun commented Mar 13, 2017

I addition to our regular Android CI build, I'm thinking about introducing a separate non-required testing build for Android. In the past, our instrumentation tests have shown to be unreliable and flaky (see #6546 for more information). To be able to make progress on these and catching regression in the meantime, a non-required build seems to be the most logical next step.

@mapbox/gl @mapbox/android @mapbox/ios

@tobrun tobrun added Android Mapbox Maps SDK for Android tests labels Mar 13, 2017
@tobrun tobrun self-assigned this Mar 13, 2017
@1ec5
Copy link
Contributor

1ec5 commented Mar 13, 2017

Note that a non-required build may allow you to merge, but GitHub will still show the commit as having failed a build in commit history.

@tobrun
Copy link
Member Author

tobrun commented Mar 13, 2017

Another idea for this would be to only run this build when a PR was merged to master?
This doesn't show up as a part of the commit history builds but will probably result in showing/catching regressions when it's too late already. More information about the trigger map in http://devcenter.bitrise.io/webhooks/trigger-map/.

@1ec5
Copy link
Contributor

1ec5 commented Mar 13, 2017

I’m referring to this commit history, which indicates whether all the builds passed for a particular merged commit. I suppose we could make the build always pass but still send some sort of failure message to Slack or elsewhere, but the build would have diminished usefulness.

This sounds like a job for Danger, which can post an inline comment in the event of a failure without actually failing the build.

@tobrun
Copy link
Member Author

tobrun commented Apr 19, 2017

Danger definitely sounds interesting (also for things as requiring changelog 😉). At the moment, we are focusing on hardening the tests which makes this issue obsolete. closing for now.

@tobrun tobrun closed this as completed Apr 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android tests
Projects
None yet
Development

No branches or pull requests

2 participants