Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Notify MGLMapViewDelegate when style loading completes #6412

Closed
1ec5 opened this issue Sep 21, 2016 · 1 comment
Closed

Notify MGLMapViewDelegate when style loading completes #6412

1ec5 opened this issue Sep 21, 2016 · 1 comment
Assignees
Labels
build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Sep 21, 2016

As of #6371, MGLMapView.mm has a compiler warning due to the new MapChangeDidFinishLoadingStyle signal not being handled by an MGLMapViewDelegate method:

Semantic Issue Group
/Users/mxn/hub/mapbox-gl-native/platform/macos/src/MGLMapView.mm:753:13: Enumeration value 'MapChangeDidFinishLoadingStyle' not handled in switch

We’ll need to add -[MGLMapView mapView:didFinishLoadingStyle:] to both the iOS and macOS SDKs. The second parameter would be an MGLStyle, at least once #6097 lands and an instance of MGLStyle sticks around a bit longer.

Adding this method will take us a little further from the set of delegate methods exposed by MapKit (#2775), but MapKit doesn’t have the concept of remote map types anyhow (at least publicly).

/cc @friedbunny

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS build macOS Mapbox Maps SDK for macOS labels Sep 21, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Sep 21, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Sep 22, 2016

A block-based style setter (#6386 (comment)) would be a fine alternative, but we need this delegate method in the meantime.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

2 participants