Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

beef up runtime styling test cases #6379

Closed
incanus opened this issue Sep 19, 2016 · 3 comments
Closed

beef up runtime styling test cases #6379

incanus opened this issue Sep 19, 2016 · 3 comments
Assignees
Labels
Android Mapbox Maps SDK for Android iOS Mapbox Maps SDK for iOS runtime styling tests
Milestone

Comments

@incanus
Copy link
Contributor

incanus commented Sep 19, 2016

On both iOS and Android in-repo test apps, we currently test:

  • Source/layer addition (GeoJSON, raster)
  • Existing Studio-made layer style changes (colors, antialiasing, widths)

However, we don't yet exercise filters, which would have revealed #6233 earlier.

I'm still possibly seeing an issue with filters and styling of existing layers even after #6233 was fixed, so rather than build a test case, I'm going to add one to the framework app.

/cc @ivovandongen @frederoni @jfirebaugh

@incanus incanus added iOS Mapbox Maps SDK for iOS Android Mapbox Maps SDK for Android tests runtime styling labels Sep 19, 2016
@incanus incanus added this to the ios-v3.4.0 milestone Sep 19, 2016
@incanus incanus self-assigned this Sep 19, 2016
@jfirebaugh
Copy link
Contributor

If you want to get really beefy, we could write a harness that can execute the test-suite runtime styling tests against the platform SDK APIs.

@incanus
Copy link
Contributor Author

incanus commented Sep 23, 2016

Apparently the subject line wasn't enough to auto-close, so: got this in #6433 with b846f54.

@incanus incanus closed this as completed Sep 23, 2016
@incanus
Copy link
Contributor Author

incanus commented Sep 23, 2016

Re: test harness @jfirebaugh, will keep this in mind as we continue to near runtime styling release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android iOS Mapbox Maps SDK for iOS runtime styling tests
Projects
None yet
Development

No branches or pull requests

2 participants