Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

circle-radius/antimeridian test is failing #5600

Closed
jfirebaugh opened this issue Jul 6, 2016 · 4 comments
Closed

circle-radius/antimeridian test is failing #5600

jfirebaugh opened this issue Jul 6, 2016 · 4 comments
Labels

Comments

@jfirebaugh
Copy link
Contributor

Revealed during the upgrade to pixelmatch4. It was passing before because the old pixelmatch had a bug where black vs. white differences weren't detected.

image

@brunoabinader
Copy link
Member

This looks similar to the symbol clip issue in #5419.

@mourner
Copy link
Member

mourner commented Jul 20, 2016

The real reason is that circles are explicitly not clipped to tile boundary in GL JS https://github.com/mapbox/mapbox-gl-js/blob/7ec9bbba94f60f188c98b0032aca57371be285fa/js/render/draw_circle.js#L15-L17, unlike the GL Native behavior.

Should we disable clipping in GL Native too, or the other way around? I'm not sure the "leaking" off the tile is the correct behavior here. cc @tmcw

@mourner
Copy link
Member

mourner commented Jul 20, 2016

OK, it looks like the real reason is not what I initially thought — stencil test is disabled for circles on native as well; however, for the 512x512 zoom 0 render test which is supposed to load z0 tile, GL JS render suite also loads adjacent "wrapped" tiles -1,0,0 and 1,0,0, and GL Native does not.

@mourner
Copy link
Member

mourner commented Jul 20, 2016

Heh, I found out that the real reason is most likely the fact we're using MapMode::Still for render tests, which disables leaking for circles and symbols. https://github.com/mapbox/mapbox-gl-native/blob/master/src/mbgl/renderer/painter_circle.cpp#L22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants