Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

add padding to annotation tiles #1673

Closed
ansis opened this issue Jun 2, 2015 · 2 comments
Closed

add padding to annotation tiles #1673

ansis opened this issue Jun 2, 2015 · 2 comments
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS

Comments

@ansis
Copy link
Contributor

ansis commented Jun 2, 2015

In order to properly sort markers across tiles (#988) we need annotation tiles to also include features that are outside of the tile's boundaries, but within a certain distance of the tile edge.

This will let us clip markers to tile boundaries at draw time to avoid incorrect overlap across tiles. Since markers near edges are included in both tiles they will be drawn seamlessly. Half the marker will be drawn by one tile and half by the other. This is how the -js implementation works.

This should be done after #1666 and #1655 are merged.

This will fix
screen shot 2015-06-02 at 11 28 57 am

After implementing, change these two lines:

// TODO remove the `&& false` when is #1673 implemented

// TODO remove the `|| true` when #1673 is implemented

@incanus
Copy link
Contributor

incanus commented Sep 1, 2015

This is stale, right @ansis?

@ansis
Copy link
Contributor Author

ansis commented Sep 3, 2015

I think this still needs to be done. But it is unblocked now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

No branches or pull requests

4 participants