Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Glyph Atlas isn't cleaned up properly #1444

Closed
kkaefer opened this issue May 6, 2015 · 8 comments
Closed

Glyph Atlas isn't cleaned up properly #1444

kkaefer opened this issue May 6, 2015 · 8 comments
Assignees
Labels

Comments

@kkaefer
Copy link
Member

kkaefer commented May 6, 2015

mapbox gl gputrace 2015-05-06 17-45-39

@mikemorris
Copy link
Contributor

Possible this is causing https://github.com/mapbox/node-mapbox-gl-native/issues/106 as well?

@friedbunny
Copy link
Contributor

friedbunny commented May 20, 2016

#3781 should improve this. The CJK glyph corruption in #1681 is likely caused by this issue.

@jfirebaugh
Copy link
Contributor

Should be fixed by #8341.

@ChrisLoer
Copy link
Contributor

Are we just hoping #8341 will fix this by shaking things up? There's a new implementation, but the tile reference counting scheme is still essentially the same.

@jfirebaugh
Copy link
Contributor

I think we should check if this issue still exists after #8341 lands. It shakes things up enough that it seems like there's a pretty good chance any remaining issue would in fact be an issue in #8341 itself.

@ChrisLoer
Copy link
Contributor

Do we have a test protocol that exposes this behavior? #8341 is in now, so this is speculatively fixed. As a simple test, I loaded a bunch of chinese tiles with the glyph atlas debug view, watched the atlas fill up with Chinese glyphs, then panned over to France, zoomed in, and watched them all get cleaned out as the tiles got pushed out of the cache. However, that's the same behavior I saw before my changes, so I'm not sure it's a useful test.

@jfirebaugh
Copy link
Contributor

In that case the bug was very likely already fixed at some point. We're pretty confident in the code now and it seems to be working, so I think this can be closed.

@kkaefer
Copy link
Member Author

kkaefer commented Apr 4, 2017

It's also possible that when I originally filed the bug, Mapbox GL was still retaining tiles in the cache, so this never really was a bug to begin with.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants