MapView hook into View removal, resolve freeze

[tobrun]

We have heard about issues of fragments not correctly integrating into our SDK due to MapView#onDestroy only being called by Fragment#onDestroy while it should be called by Fragment#onDestroyView.

The underlying issue is that the render surface needs to be destroyed before we remove the hosting view. We should analyse if it's possible to hook into view removal and call MapView#onPause/MapView#onStop/MapView#onDestroy as part of it.

[tikimcfee]

We should analyse if it's possible to hook into view removal and call MapView#onPause/MapView#onStop/MapView#onDestroy as part of it.

+1! +5! This would be great! It's tough to get some attach/detach flows working from the outside looking in when doing things like animation or manual view management (remove and reattach somewhere else). Wish you luck on this, and hope the Android view listening APIs give ya enough info.

[tobrun]

Announced at Google I/O was the following editor for app flow:

It looks like the code generated for that shows using a static fragment:

Since this issue is reproducible with static fragments, I think we should prioritize this.

cc @mapbox/maps-android

[stale]

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

[ghost]

Any updates on this issue?

[tobrun]

Yes, still under investigation, the gist is that we try to cleanup the map while the render thread is already destroyed. We need a refactoring in setup to resolve this.

[tobrun]

The issue was introduced as part of 18bb6da. There are situations where the underlying GL render thread is already destroyed (one example being Fragment setup with destroy/destroyView ). In those case it freezes as resetRenderer is never called.

[fredo-]

Sorry, I'm still a little confused @tobrun. How does this last merge request fix issue #10205?
My main issue being: if I'm using Conductor with Mapbox, where do I call mapView.onDestroy()? Since calling it in Conductor's onDestroyView() crashes the app.

[zugaldia]

@fredo- thanks for the feedback on Conductor. Would you mind cutting a separate ticket about the issue you're seeing to avoid conflating the two conversations?

[kshailes]

I can't find solution anywhere? How is it closed?

[zugaldia]

@kshailes we believe this issue was solved by #13926. If you're still observing this freeze, please cut a separate ticket on https://github.com/mapbox/mapbox-gl-native-android and the team will follow up. Thanks.