Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add data-driven-styling support for text-font #10535

Closed
jfirebaugh opened this issue Nov 22, 2017 · 1 comment · Fixed by #10850
Closed

Add data-driven-styling support for text-font #10535

jfirebaugh opened this issue Nov 22, 2017 · 1 comment · Fixed by #10850
Assignees
@jfirebaugh
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Milestone
ios-v4.0.0-boba

Comments

@jfirebaugh
Copy link
Contributor

Port mapbox/mapbox-gl-js#5698 / mapbox/mapbox-gl-js#5568.
@jfirebaugh jfirebaugh added Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS labels Nov 22, 2017
@jfirebaugh jfirebaugh mentioned this issue Dec 11, 2017
Open
@1ec5
Copy link
Contributor

1ec5 commented Dec 20, 2017

#10620 pulled in a new version of the style specification that includes the changes from mapbox/mapbox-gl-js#5698. As a result, running make style-code now changes the text-font implementations to assume data-driven styling support. In #10726, the iOS/macOS runtime styling code generation script manually overrides that change (as well as heatmap/hillshade layers).

@jfirebaugh jfirebaugh self-assigned this Jan 5, 2018
@jfirebaugh jfirebaugh mentioned this issue Jan 5, 2018
Merged
@jfirebaugh jfirebaugh added this to the ios-v4.0.0 milestone Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jfirebaugh jfirebaugh

Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Milestone
ios-v4.0.0-boba
Development

Successfully merging a pull request may close this issue.

Add data-driven-styling support for text-font mapbox/mapbox-gl-native
2 participants
@jfirebaugh @1ec5