From 19c24c01051a134d262b9fb4e1771c7da5d27385 Mon Sep 17 00:00:00 2001 From: Chloe Krawczyk Date: Thu, 5 Mar 2020 01:05:59 -0800 Subject: [PATCH 1/3] make the differences with/without overlap more obvious --- src/style-spec/reference/v8.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/style-spec/reference/v8.json b/src/style-spec/reference/v8.json index 587838ef31e..157b2928ad1 100644 --- a/src/style-spec/reference/v8.json +++ b/src/style-spec/reference/v8.json @@ -1025,7 +1025,7 @@ }, "symbol-sort-key": { "type": "number", - "doc": "Sorts features in ascending order based on this value. Features with a higher sort key will appear above features with a lower sort key when they overlap. Features with a lower sort key will have priority over other features when doing placement.", + "doc": "Sorts features in ascending order based on this value. Features with a higher sort key will appear above other features when they overlap. Features with a lower sort key will have priority over other features during placement when they do not overlap.", "sdk-support": { "basic functionality": { "js": "0.53.0", From c0375b8752a0579269aa0b8bd4d56b5f27b9ce2d Mon Sep 17 00:00:00 2001 From: Chloe Krawczyk Date: Fri, 6 Mar 2020 15:56:33 -0800 Subject: [PATCH 2/3] make it more obvious that user toggles overlap --- src/style-spec/reference/v8.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/style-spec/reference/v8.json b/src/style-spec/reference/v8.json index 157b2928ad1..a1bb68eaec6 100644 --- a/src/style-spec/reference/v8.json +++ b/src/style-spec/reference/v8.json @@ -1025,7 +1025,7 @@ }, "symbol-sort-key": { "type": "number", - "doc": "Sorts features in ascending order based on this value. Features with a higher sort key will appear above other features when they overlap. Features with a lower sort key will have priority over other features during placement when they do not overlap.", + "doc": "Sorts features in ascending order based on this value. When `*-allow-overlap` is enabled for symbols, features with a higher sort key will appear above other features. When overlap is disabled, features with a lower sort key will have priority over other features during placement.", "sdk-support": { "basic functionality": { "js": "0.53.0", From a7fe198fa5892b034aa7aa11a52127091e6175e7 Mon Sep 17 00:00:00 2001 From: Chloe Krawczyk Date: Mon, 9 Mar 2020 17:20:54 -0700 Subject: [PATCH 3/3] third time's the charm --- src/style-spec/reference/v8.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/style-spec/reference/v8.json b/src/style-spec/reference/v8.json index a1bb68eaec6..525700a109c 100644 --- a/src/style-spec/reference/v8.json +++ b/src/style-spec/reference/v8.json @@ -1025,7 +1025,7 @@ }, "symbol-sort-key": { "type": "number", - "doc": "Sorts features in ascending order based on this value. When `*-allow-overlap` is enabled for symbols, features with a higher sort key will appear above other features. When overlap is disabled, features with a lower sort key will have priority over other features during placement.", + "doc": "Sorts features in ascending order based on this value. Features with lower sort keys are drawn and placed first. When `icon-allow-overlap` or `text-allow-overlap` is `false`, features with a lower sort key will have priority during placement. When `icon-allow-overlap` or `text-allow-overlap` is set to `true`, features with a higher sort key will overlap over features with a lower sort key.", "sdk-support": { "basic functionality": { "js": "0.53.0",